reptil1990/AquaMasterMQTT
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 231 Wiki Activity

feat/rtc-pcf8523 #3

Merged
reptil1990 merged 10 commits from feat/rtc-pcf8523 into main 2026-05-03 16:28:05 +02:00
Conversation 0 Commits 10 Files Changed 9 +1053 -43
reptil1990 commented 2026-05-03 16:27:59 +02:00
Owner
Copy Link

Implement RTC and add NEU label

Implement RTC and add NEU label
reptil1990 added 10 commits 2026-05-03 16:27:59 +02:00
docs: add design spec for PCF8523 RTC fallback 96fcb74c80 
New header rtcsync.h providing persistent time storage and offline
fallback when NTP is unavailable. Soft-fails when hardware is absent.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
docs: add implementation plan for PCF8523 RTC fallback df95a37ca7 
Ten tasks covering dependency setup, header creation, weak-hook
decoupling from timesync.h, master.cpp wiring, and hardware
verification on real device.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
build: add RTClib dependency for PCF8523 RTC support f6b2dceedc
feat(rtc): add rtcsync.h with PCF8523 detection and time fallback a875b20ba2
feat(rtc): wire timesync hooks and add persistSystemTimeToRTC 781ad18c6a
feat(rtc): add syncFromNTP wrapper that persists to RTC 68483c8127
feat(rtc): add loopRTC and appendTimeStatus hook 8acb611b9b
feat(rtc): wire rtcsync into setup and loop a6c885ee33
fix(rtc): address code-review findings (5 fixes) fa87fd0222 
- Drop extern "C" from weak hooks (UB with C++ reference param)
- syncTimeWithNTP returns bool; syncFromNTP uses it (robust success check)
- Avoid duplicate NTP sync at boot (wificlass already syncs)
- Clamp negative time deltas in 24h timer and JSON status
- Cache rtc.now() in loopRTC to avoid I2C race with PN532
glow für neue Zeit
Some checks failed
/ build (push) Failing after 4m11s
Details
3400b9cc6a
reptil1990 merged commit f558c64886 into main 2026-05-03 16:28:05 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
reptil1990
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: reptil1990/AquaMasterMQTT#3
Delete Branch "feat/rtc-pcf8523"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?